[RESOLVED](XP)Creature Still Dies If Element Set to E=0%

Started by MeVII, March 02, 2010, 08:13:40 pm

Previous topic - Next topic

MeVII

Thread Summary:

      I was having issues with elements set to have 0% effect on creatures still killing them.
      Blizzard said to make a demo so hed look at it.
      Blizzard noticed my mention of Tons of AddOns in my explanation and recommended an upgrade.
      I explained I had upgraded, and confirmed it was the most recent version.
      Blizzard recommended the fix of changing line 3793 in ToAO v7.39b Section#2
Recommended Changes: ShowHide
       From this...
SKILL_SETS = [9, 10, 11, 12, 13, 14, 15, 16]

      To this...
SKILL_SETS = []
Simply delete the preset numbers.


      Thanks for the input Blizzard! :)

                                                                                             MeVII

Original 1st Post: ShowHide
I was testing my skills today, and Im very confused. I have hope that someone can help.

A test skill is set to one element (test), and add one state (test).
The state (test) is set to add one state (test).
The test enemy is set to E (0%) for the element (test), and F (0%) for state efficiency (test).
When the skill is used, the test enemy still takes damage and dies.
This happens even when ALL elements are set to F (-100%), and ALL states are set to F (0%).
Why wont those settings make the enemy immune to the skill?
I am not using any dummy elements.
I am using the
class Game_Battler
 $DUMMY_ELEMENTS = [] if $DUMMY_ELEMENTS == nil
 def elements_correct(elements)
   return 100 if elements.size == 0
   multiplier = 0
   size = 0
   elements.each {|i|
       if !$DUMMY_ELEMENTS.include?(i) && self.element_rate(i) != 100
         multiplier += self.element_rate(i)
         size += 1
       end}
   return 100 if size == 0
   return multiplier/size
 end
end


So, Im lost.

Any input? Thanks to all!

                                                                                       MeVII

Edit 3/4/10
I just thought of this after I sent off a private msg to someone ...Is this because skills all do a "base" or "non-elemental" dammage on top of, or modified by the element? Hence, a skill with no element at all, would still do damage? Or in other words, is no way to make a creature totally immune to the damage to a specific element through element settings?

 

Blizzard

Hm... It could be some script messing up something. Make a small demo and I can take a look at it.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

MeVII

March 07, 2010, 03:18:03 pm #2 Last Edit: March 07, 2010, 03:19:46 pm by MeVII
Hey Bliz, thanks for looking into this!

Since grunt work is one of the things Im good at, in making the demo,
I zeroed in as best as I could on whats causing the issue.
Something in Tons of AddOns (or something else that is conflicting with it),
seems to be causing issues with any element IDs 9 and up.

I have the test enemy set to E for all elements.
I then sequentially went from Test Element 1 through TE15,
all element IDs 9 and up damage the target regardless of its "E" setting.

I removed ToAO and I could no longer replicate the issue.
I then removed all other scripts except ToAO, and the issue resumed.

I reinserted the other scripts as I was using them, then I updated ToAO.
I was using ToAO 6.81b, I updated to 7.39b and the issue resumed.
7.39b is "raw", as in, after importing it, I did zero configuration to its settings.

HERE is the demo (505kb). The error can be seen in the troop battle test,
so the demo is "unrunable", blank and no start location etc...

Thanks again for your time in helping!

And lets face it, we all know your going to fix this. So *POWERUP* in advance.  ;)

                                                                                                   MeVII
 

Blizzard

Oh, wait a moment! If you're saying that Tons could be causing the issue, you should update it. I remember that there was a problem with the default setup for the Skill Separation System. It would automatically configure the IDs above 9 to be dummy elements. I think that I fixed that so updating Tons should fix the issue.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

MeVII

March 08, 2010, 09:53:13 am #4 Last Edit: March 08, 2010, 10:04:32 am by MeVII
Heya!

After I got that far, updateing ToAO was the first thing I did.

QuoteI was using ToAO 6.81b, I updated to 7.39b and the issue resumed.
7.39b is "raw", as in, after importing it, I did zero configuration to its settings.


I got 7.39b from HERE.
Is there a more recent version somewhere else?

Just to be sure, I checked my demo, all 3 segments are 7.39b, and the error is still occurring.

I took a look at it, and ToAO 7.39b section2, (SSS) v1.33b: 5.10.2009, lines 3792-3793, are
# your skill set dummy elements
SKILL_SETS = [9, 10, 11, 12, 13, 14, 15, 16]


So I made 17 elements, and sure enough, element 17 functions normally.

Just to make sure, I checked config, and (SSS) is set to false.
@SKILL_SEPARATION       = false


I suppose a quick fix would be to empty that section of the config,
or set them to way up there in the 100s, but I presume you want to know
why its doing that even while set to "false".

Thats the best I can do ... which was redundant if theres a more updated version that Im overlooking.
If thats the case, point me to it please. Cuz Ima not have found it. :)

                                                                                                         MeVII
 

Blizzard

Delete the numbers (set it to []) and it should work then.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.