[XP] Tons of Add-ons

[Makasu]

Ahh yes just what I needed! Thank you very much Blizz *lv+*

[G_G]

Not sure if its worth finishing other then get 35$ out of my friend but its a complete Tons of Add-Ons Config App this is part of the layout and its got alot of work...

Spoiler: ShowHide

Not sure if its even a good idea making it but I get 35 bucks from my friend from doing it. I started charging him for scripts and programs I make for him because he asks for so many.

[Aqua]

He's paying you $35 just so he can be lazy? O.o

[G_G]

Yup pretty much, anyone think its a good idea?

I thought it was ok but seriously theres only so much lazyness you can have...or is there?

[tSwitch]

this is weird, no matter what I do whenever I use a Revenge skill it pops up "Miss"

edit: same with Demi moves, they always miss :/

[legacyblade]

He's paying you $35 just so he can be lazy? O.o

Why do you think people hire computer technicians and commuter support? The majority of my money comes from doing really simple tasks that the company is too lazy to do/figure out for themselves. lol. Game_Guy, finish the project with as much speed as possible (while keeping the work good), it it might appeal to his lazy side so much that he'll ask you for more work.

[tSwitch]

lol nvm

[tSwitch]

I used a revenge skill and it healed my opponent ._.

[Magus]

rofl

[tSwitch]

self.damage = self.maxhp - user.hp 

doesn't work if enemies use a Revenge skill.
I changed it to

self.damage = user.maxhp - user.hp 

now it does

[Blizzard]

._.;;;

EDIT: Fixed. Funny that nobody noticed it so far.

[Rezca]

This should likely be more appropriate being posted in the Script Troubleshooting subforum, but it only came up with the most recent version of Tons of Scripts.

Thus far I have been using your pack with version 6.xb, and upon downloading 7.x (I had been absent in the RPG Maker for several months) found that each battle crashes the game upon my characters turn.

Script 'AddOn Pack 2' line 3814: ArgumentError occurred.

wrong number of arguments(0 for 1)

The position of the script in the Script Editor hierarchy does not change anything. Complete list of scripts below. (No I am not using any SDK scripts.)

AddOn Pack 1
AddOn Pack 2
AddOn Pack 3
Emoticon Event (By Nechigawara Sanzenin)
Damaging and Healing Floor Tiles (Author unknown?)
Sideview Battle System Version 2.1xp (By Enu, Atoa, Kylock, Mr. Bubble, cairn)
* SBS Config
* Sideview 1
* Sideview 2
Advanced Collapse (By Enu)
Leon's Shopping System
Kylock's Gun-AddOn
Example Skills (By Atoa and Enu I think...)

Ehh... If this truly is related to your AddOn collection and not a compatability issue, you can just ignore it 

[Aqua]

It's the SBS making a method differently.

You'd have to provide the method that Tons is erroring on and that same method that's in the SBS for a fix...

(Or if you want a fix yourself...
The method in the SBS should have something like "method_name(something_here = default_value)" while Tons only has "method_name".
Change Tons to "method_name(something_here = default_value) to fix the problem.

[Rezca]

I'll try fixing it myself for two reasons: One, because it's kinda my fault to begin with having two complex systems in one game, and Two:  I need to learn how Ruby works if I'm ever going to understand it  

This is the section that the message referred to, in any case.

#==============================================================================
# Game_Battler
#==============================================================================

class Game_Battler
  
  alias elements_correct_sss_later elements_correct
  def elements_correct(elements)
    return elements_correct_sss_later if !$game_system.SKILL_SEPARATION #This part the error referred to...
    multiplier = size = 0
    elements.each {|i|
        unless $DUMMY_ELEMENTS.include?(i)
          multiplier += self.element_rate(i)
          size += 1
        end}
    return (size == 0 ? 100 : multiplier / size)
  end
  
end

[samsonite789]

I'm afraid I found another bug.

Now, when I put the latest version of addons underneath all my other scripts (including RTAB), it gives me the following error when I attack a monster:

Script 'Real Time Active Battle' line 1569: ArgumentError occurred
wrong number of arguments (1 for 0)

The code it's referring to is as follows:

#==============================================================================
# ** Scene_Battle
#------------------------------------------------------------------------------
#  This class performs battle screen processing.
#==============================================================================

class Scene_Battle
  #-------------------------------------------------------------------------- 
  # * Action renewal (main phase)
  #--------------------------------------------------------------------------
  def action_phase(battler)
    # When action 1 is, verification whether or not the battler while acting
    if @action == 1 and battler.phase <= 3
      for target in battler.target
        speller = synthe?(target)
        if speller == nil
          # When the target is in the midst of usual acting,
          if @action_battlers.include?(target) 
            if target.phase > 2 and battler.phase < 3              
              return
            end
          end
        else
          # When the target is in the midst of cooperation skill moving,
          for spell in speller
            if @action_battlers.include?(spell)
              if spell.phase > 2
                return
              end
            end
          end
        end
      end
    end
    case battler.phase
    when 1
      update_phase4_step1(battler)
    when 2
      update_phase4_step2(battler)
    when 3
      update_phase4_step3(battler)
    when 4
      update_phase4_step4(battler)
    when 5
      update_phase4_step5(battler)  <--- This line
    when 6
      update_phase4_step6(battler)
    end
  end
end

I CTRL-F'ed update_phase4_step5 and found that several methods in the second and third part of the addons set batter to nil.  Perhaps that's doing it?  I don't know...I'm a little out of my depth here.

[Blizzard]

I'll take a look at it.

@Rezca: That has been fixed in v7.37b.

EDIT: Update to v7.39b.

@sam: Thanks for testing it with RTAB. I didn't have time to test the newest add-ons with RTAB properly so this RTAB bug hunt is helping out quite a bit. xD

[samsonite789]

Blizzard,

No, thank YOU 

Anyway, it works!  You rock!  I can now place it underneath RTAB and all my other scripts and it doesn't bug out in battle.

However, another problem remains...the majority of the status and skill scripts don't work.  Most of them don't output any errors, they just simply don't do anything even when turned on and properly configured.  I have a LOT of scripts, so this makes me think it's just a general compatability/overwriting error.  I've managed to duplicate the effects of a lot of these skill add-ons using event systems anyway, so it shouldn't be a huge problem.  There is one add-on, Unique Battle Commands, that I wanted to use so very much but that also doesn't do anything.  I'd like to ask you if you could help fix that but without a frame of reference (i.e. an error message) it seems like it'd be like finding a needle in a haystack.

Here's one error for you...when I use the Regen Status add-on, as soon as I cast Regen on a character, it gives me the following error:

Script 'Tons of Addons' line 359: NoMethodError occurred
undefined method '+' for {}:Hash

That is this code:

Spoiler: ShowHide

#==============================================================================
# Game_Battler
#==============================================================================

class Game_Battler

  alias slip_damage_regen_later? slip_damage?
  def slip_damage?
    if $game_system.REGEN_STATUS && !$scene.is_a?(Scene_Map) &&
        (HP_REGEN_IDS + SP_REGEN_IDS + SP_POISON_IDS).any? {|i| @states.include?(i)}
      return true
    end
    return slip_damage_regen_later?
  end
  
  alias slip_damage_effect_regen_later slip_damage_effect
  def slip_damage_effect
    if $game_system.REGEN_STATUS
      if !(HP_REGEN_IDS.any? {|i| @states.include?(i)}) &&
          slip_damage_regen_later?
        slip_damage_effect_regen_later
      elsif (HP_REGEN_IDS.any? {|i| @states.include?(i)}) &&
          !slip_damage_regen_later?
        dam = -self.maxhp / 10
        if dam.abs > 0
          amp = [dam.abs * 15 / 100, 1].max
          dam -= rand(amp+1) + rand(amp+1) - amp
        end
        self.hp -= dam
        self.damage = 0 if self.damage == nil
        self.damage += dam   <---THIS LINE
      end
      if (SP_REGEN_IDS.any? {|i| @states.include?(i)}) !=
          (SP_POISON_IDS.any? {|i| @states.include?(i)})
        dam = self.maxsp / 10
        if dam > 0
          amp = [dam * 15 / 100, 1].max
          dam += rand(amp+1) + rand(amp+1) + amp
        end
        dam = -dam if SP_REGEN_IDS.any? {|i| @states.include?(i)}
        self.sp -= dam
        self.damage = 0 if self.damage == nil
        self.damage += dam
      end
    else
      slip_damage_effect_regen_later
    end
  end

I tried setting the Regen skill to using Slip Damage, and then the error went away but it simply didn't do anything like the other skill add-ons.

I'm guessing this is just conflicts with my multitude of other scripts, but is there something I'm missing?  Thanks again!

[Blizzard]

Hm... There is simply a general problem with RTAB. I should have some free time by the end of the week. I'll go through all add-ons that could be causing problems and test them with RTAB properly.

[Calintz]

Do you think you could add the beserk skill??
Enraged characters with automated attacks??

You could do this by setting up pre-defined tendencies within the script much like in the enemy database.
Using numbers 1-100 you could emulate percentage to set priorities ...

[Holyrapid]

That could be easily evented in a common event... like this:
if chr a status bersek inflicted force action attack
add just a boost to stat´s if needed... Or is there a special reason you´d want it to be in a script?