Bugs after upgrade to SMF 2

Started by Blizzard, December 27, 2015, 04:57:13 pm

Previous topic - Next topic

Blizzard

December 27, 2015, 04:57:13 pm Last Edit: December 27, 2015, 05:06:50 pm by Blizzard
Post all the bugs you find here and we will see if somebody can take the time to fix them.

Make sure to mention on which theme you encountered the bug! If possible, please test if the same bugs happens on other themes as well. And remember to post your browser as well.

One post per bug is fine. That way we can easily track the bugs already fixed.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Blizzard

December 27, 2015, 05:01:10 pm #1 Last Edit: January 20, 2017, 03:13:44 am by Blizzard
Bug:
Code block is very small inside spoilers.

Themes:
GamerZ, Astonished, Smooth, Elegant Mind

Browser:
Opera Next, Chrome

Reproduction:
Just open any spoiler that has [code] tags inside.

Notes:
Likely be browser related. We used to have this issue on SMF 1.1.x.


Fixed. :3
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Blizzard

December 27, 2015, 05:01:56 pm #2 Last Edit: December 27, 2015, 05:06:59 pm by Blizzard
Bug:
Custom title is displayed below avatar instead above user group (like on old forum).

Theme:
GamerZ

Browser:
Opera Next

Reproduction:
Open any topic.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Blizzard

Bug:
The member group icons aren't displayed.

Theme:
GamerZ, Smooth, Elegant Mind, Astonished

Browser:
Opera Next

Reproduction:
Open any topic.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Blizzard

Bug:
No avatar or other user info is displayed in topics.

Theme:
Smooth

Browser:
Opera Next

Reproduction:
Open any topic.

Notes:
It seems that this feature simply isn't implemented in the theme.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Blizzard

Bug:
Our affiliated aren't displayed.

Theme:
GamerZ, Smooth, Elegant Mind, Astonished

Browser:
Opera Next

Reproduction:
They should be visible at the bottom or something like that.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Blizzard

December 27, 2015, 05:34:25 pm #6 Last Edit: December 28, 2015, 06:02:21 am by Blizzard
Bug:
There's a permanent horizontal scrollbar

Theme:
Astonished (didn't test others)

Browser:
Opera Next

Reproduction:
It happens on any page and on any resolution / window size.


KK20: I don't see this horizontal scroll bar on all themes in Chrome.

by Blizz: Fixed. The problem seems to appear, because the theme widths were 98%. I fixed it by changing it to 95%.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

winkio

December 27, 2015, 06:25:10 pm #7 Last Edit: December 28, 2015, 03:17:13 am by Blizzard
Bug:
The [url][/url] tags for youtube links are not working right (see http://forum.chaos-project.com/index.php/topic,68.2500.html).  Some youtube tag gets added to them, but not to other links.

Theme:
Astonished (didn't test others)

Browser:
Chrome

Reproduction:
It seems to happen on any url link to youtube


by Blizz: Fixed. LMAO, it turns out that the add-on for YT tags doesn't work, but that SMF 2 already supports them by default.

KK20

December 27, 2015, 09:28:21 pm #8 Last Edit: December 28, 2015, 07:24:09 am by Blizzard
Bug:
If spoiler has text (spoiler=TEXT_HERE), some BBC within it appear to not work (http://forum.chaos-project.com/index.php/topic,12164.0.html).

Theme:
GamerZ, Smooth, Elegant Mind, Astonished

Browser:
Chrome

Reproduction:

SAMPLE TEXT: ShowHide

This turned bold

This is a failed code block.


  • This list

  • also failed




by Blizz: Fixed.





   


   
   


   
   

Other Projects
RPG Maker XP AceUpgrade RMXP to RMVXA performance!
XPA TilemapTilemap rewrite with many features, including custom resolution!



Nintendo Switch Friend Code: 8310-1917-5318
Discord: KK20 Tyler#8901

Join the CP Discord Server!

Blizzard

December 28, 2015, 03:14:29 am #9 Last Edit: December 28, 2015, 05:59:04 am by Blizzard
Bug:
Our anti-spam protection is shit. It does use captcha, but that's proven to let through spam accounts all the time.

Theme:
all

Browser:
all

Reproduction:
Try to register a new account. We should bring back our old anti-spam protection.


by Blizz: Fixed.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

winkio

Bug:
Forum does not update the last read post in a topic

Theme:
Smooth

Browser:
Chrome

Reproduction:
I can't tell if it started after the update, or after switching to the Smooth theme, but the forum is no longer updating the posts I read in topics.  It always takes me to the last post I read either before the conversion or before I switched themes.

Blizzard

January 03, 2016, 02:57:33 pm #11 Last Edit: January 05, 2016, 06:24:42 am by Blizzard
Bug:
Most BBCode tags don't work in the shoutbox.

Theme:
Astonished (not tested, but probably in all)

Browser:
Chrome

Reproduction:
Just try using [spoiler][/spoiler] or [img][/img] or another tag in the shoutbox.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Ryex

Bug:
Syntax Highlighting is broken and doesn't seem to be in use (may be as simple as an uninstall and reinstall of the mod)

Theme:
ChaosNew

Browser:
Chrome

Reproduction:
view a code block.
I no longer keep up with posts in the forum very well. If you have a question or comment, about my work, or in general I welcome PM's. if you make a post in one of my threads and I don't reply with in a day or two feel free to PM me and point it out to me.<br /><br />DropBox, the best free file syncing service there is.<br />

KK20

I like how we kinda just accepted the horrible bugs and forgot they even existed xP

Quote from: Blizzard on December 27, 2015, 05:01:10 pm
Bug:
Code block is very small inside spoilers.

Themes:
GamerZ, Astonished, Smooth, Elegant Mind

Browser:
Opera Next, Chrome

Reproduction:
Just open any spoiler that has [code] tags inside.

Notes:
Likely be browser related. We used to have this issue on SMF 1.1.x.

One I would really like to see fixed at some point. I have only seen it work correctly on Firefox 45. If you click the spoiler before the page fully loads on Chrome, it works too.





   


   
   


   
   

Other Projects
RPG Maker XP AceUpgrade RMXP to RMVXA performance!
XPA TilemapTilemap rewrite with many features, including custom resolution!



Nintendo Switch Friend Code: 8310-1917-5318
Discord: KK20 Tyler#8901

Join the CP Discord Server!

Blizzard

Something's probably weird with the formatting code. :/
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

Ryex

August 11, 2016, 01:07:16 am #15 Last Edit: August 11, 2016, 01:14:55 am by Ryex
ya, some how the syntax highlighter  doesn't pickup code tags inside spoilers. we fixed it before but I don't remember how.

Edit: wait what? the code syntax highlighter isn't even there! what happened?
the javascript code is gone completely from the header. is the mode even installed? I know I had it edited to work properly.
I no longer keep up with posts in the forum very well. If you have a question or comment, about my work, or in general I welcome PM's. if you make a post in one of my threads and I don't reply with in a day or two feel free to PM me and point it out to me.<br /><br />DropBox, the best free file syncing service there is.<br />

KK20

January 04, 2017, 08:14:03 pm #16 Last Edit: January 04, 2017, 08:22:25 pm by KK20
I've been on a TamperMonkey script making kick lately, so I wanted to take a look at the spoilered code tags again.

The CSS for code blocks is this. Note the overflow: auto
http://forum.chaos-project.com/Themes/ChaosNew/css/index.css?fin20

/* A code block - maybe PHP ;). */
code.bbc_code
{
display: block;
font-family: "dejavu sans mono", "monaco", "lucida console", "courier new", monospace;
font-size: x-small;
background: #ffeeee;
border-top: 2px solid #999;
border-bottom: 2px solid #999;
line-height: 1.5em;
padding: 3px 1em;
overflow: auto;
white-space: nowrap;
/* Show a scrollbar after about 24 lines. */
max-height: 24em;
}

Code tags were being injected with a style="height: 20px" so I started digging around the JS files and found this:
http://forum.chaos-project.com/Themes/ChaosNew/scripts/theme.js?fin20

// The purpose of this code is to fix the height of overflow: auto blocks, because some browsers can't figure it out for themselves.
function smf_codeBoxFix()
{
var codeFix = document.getElementsByTagName('code');
for (var i = codeFix.length - 1; i >= 0; i--)
{
if (is_webkit && codeFix[i].offsetHeight < 20)
codeFix[i].style.height = (codeFix[i].offsetHeight + 20) + 'px';

else if (is_ff && (codeFix[i].scrollWidth > codeFix[i].clientWidth || codeFix[i].clientWidth == 0))
codeFix[i].style.overflow = 'scroll';

else if ('currentStyle' in codeFix[i] && codeFix[i].currentStyle.overflow == 'auto' && (codeFix[i].currentStyle.height == '' || codeFix[i].currentStyle.height == 'auto') && (codeFix[i].scrollWidth > codeFix[i].clientWidth || codeFix[i].clientWidth == 0) && (codeFix[i].offsetHeight != 0))
codeFix[i].style.height = (codeFix[i].offsetHeight + 24) + 'px';
}
}

Specifically the is_webkit part. Also makes sense why Firefox was working fine as evident by the next if-statement.
I'm not sure what the consequences could be for removing the few lines, but removing the style.height seemed to be fine for Chrome.





   


   
   


   
   

Other Projects
RPG Maker XP AceUpgrade RMXP to RMVXA performance!
XPA TilemapTilemap rewrite with many features, including custom resolution!



Nintendo Switch Friend Code: 8310-1917-5318
Discord: KK20 Tyler#8901

Join the CP Discord Server!

Blizzard

Can you try this with a few other browsers, including IE and Edge?
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.

KK20

Not at the moment, but I can when I'm at work tomorrow.

EDIT: Removing the style.height on Edge 14 looked fine. IE8 wasn't affected at all by the JS.





   


   
   


   
   

Other Projects
RPG Maker XP AceUpgrade RMXP to RMVXA performance!
XPA TilemapTilemap rewrite with many features, including custom resolution!



Nintendo Switch Friend Code: 8310-1917-5318
Discord: KK20 Tyler#8901

Join the CP Discord Server!

Blizzard

I'll do the changes then when I catch some free time.
Check out Daygames and our games:

King of Booze 2      King of Booze: Never Ever
Drinking Game for Android      Never have I ever for Android
Drinking Game for iOS      Never have I ever for iOS


Quote from: winkioI do not speak to bricks, either as individuals or in wall form.

Quote from: Barney StinsonWhen I get sad, I stop being sad and be awesome instead. True story.